Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-pre): do not alter attributes (fix #10087) #10088

Merged
merged 4 commits into from
Sep 21, 2020

Conversation

xmakina
Copy link
Contributor

@xmakina xmakina commented May 30, 2019

Fix #10087

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
When attributes under a v-pre match the list in isBooleanAttr, the value is replaced. This goes against the purpose of v-pre which is to leave all elements as-is.

An example of this bug can be found at https://jsfiddle.net/fp1omdaw/1/ as well as further details under #10087

@PhilipJohnBasile
Copy link

👍

test/unit/features/directives/pre.spec.js Outdated Show resolved Hide resolved
test/unit/features/directives/pre.spec.js Outdated Show resolved Hide resolved
remove component and replace option from unit test
if (el.tagName.indexOf('-') > -1) {
baseSetAttr(el, key, value)
} else if(isInPre) {
if (el.tagName.indexOf('-') > -1 || isInPre) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't checking isInPre first be more optimal?

@posva posva merged commit 0664cb0 into vuejs:dev Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes listed under isBooleanAttr are altered under v-pre attributed tags
4 participants