Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): new Vue() improvements (#12730) #12737

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

gulewei
Copy link
Contributor

@gulewei gulewei commented Aug 11, 2022

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Type inference improvements, close #12730

@yyx990803
Copy link
Member

Thanks for the PR!

I made a small change since the option name is mixins, not mixin, but this causes existing test cases to be broken so the change conflicts with existing inference.

@gulewei
Copy link
Contributor Author

gulewei commented Aug 15, 2022

Thanks for the PR!

I made a small change since the option name is mixins, not mixin, but this causes existing test cases to be broken so the change conflicts with existing inference.

Sorry that I didn't notice the option name. And I'll try to fix where is broken.

@gulewei
Copy link
Contributor Author

gulewei commented Aug 16, 2022

I made some changes to use defineComponent for inference, now it could support more complex mixins and has checked nothing is broken.

@yyx990803 yyx990803 merged commit 89a6b5e into vuejs:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new Vue cannot infer mixin types
2 participants