Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add create-element tests #2930

Merged
merged 1 commit into from May 23, 2016
Merged

add create-element tests #2930

merged 1 commit into from May 23, 2016

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented May 20, 2016

ref: #2872

yyx990803
yyx990803 reviewed May 20, 2016
View reviewed changes
test/unit/modules/vdom/create-element.spec.js
expect(vnode.ns).toBeUndefined()
expect(vnode.context).toEqual(vm)
expect(vnode.componentOptions).toBeUndefined()
expect(`Unknown custom element: <${tag}> - did you`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing toHaveBeenWarned()?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@yyx990803 yyx990803 merged commit 30c8219 into vuejs:next May 23, 2016
@kazupon kazupon deleted the test/create-element branch May 25, 2016 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kazupon @yyx990803