Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent nested thunk children from failing #3367

Merged
merged 1 commit into from
Aug 1, 2016
Merged

prevent nested thunk children from failing #3367

merged 1 commit into from
Aug 1, 2016

Conversation

chrisvfritz
Copy link
Contributor

This prevents avoidable failures in some cases, for example in a functional component using JSX that produces a double thunk:

render: (h, { children }) => <MyComponent>{ children }</MyComponent>

@posva
Copy link
Member

posva commented Aug 1, 2016

As this may get executed often, is it worth changing the recursion with a while loop? even thought it is less readable?

@yyx990803 yyx990803 merged commit d9d4e7f into vuejs:next Aug 1, 2016
@chrisvfritz
Copy link
Contributor Author

@posva Good idea! I don't think it's really less readable - just less functional, which is fine. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants