Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spelling #3496

Merged
merged 2 commits into from Aug 22, 2016
Merged

Fix Spelling #3496

merged 2 commits into from Aug 22, 2016

Conversation

BrandonSurowiec
Copy link
Contributor

No description provided.

@posva
Copy link
Member

posva commented Aug 22, 2016

Thanks for pointing it out. It's actually on more places. If you could replace all the occurences and add it to the PR, that would be perfect 👌

packages/vue-server-renderer/build.js
3462:        process.env.NODE_ENV !== 'production' && warn$1('Templates should only be responsbile for mapping the state to the ' + 'UI. Avoid placing tags with side-effects in your templates, such as ' + ('<' + tag + '>.'));

packages/vue-template-compiler/build.js
3244:        process.env.NODE_ENV !== 'production' && warn$1('Templates should only be responsbile for mapping the state to the ' + 'UI. Avoid placing tags with side-effects in your templates, such as ' + ('<' + tag + '>.'));

src/compiler/parser/index.js
93:          'Templates should only be responsbile for mapping the state to the ' +

test/unit/modules/compiler/parser.spec.js
64:    expect('Templates should only be responsbile for mapping the state').toHaveBeenWarned()
71:    expect('Templates should only be responsbile for mapping the state').toHaveBeenWarned()

@BrandonSurowiec
Copy link
Contributor Author

@posva Done!

@posva posva merged commit 0f8ad06 into vuejs:next Aug 22, 2016
@yyx990803
Copy link
Member

@BrandonSurowiec @posva in the future please make sure to only modify src files - the build.js in packages are auto-generated and only updated when the package is published during releases.

@posva
Copy link
Member

posva commented Aug 23, 2016

@yyx990803 My bad. I'll remember next time 👍

@BrandonSurowiec
Copy link
Contributor Author

@yyx990803 Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants