compatibility problem of SSR with ES5

[speedornothing]

bundle rendering doesn't work if exports a function using module.exports = function(context).. instead of export default context => ... in server entry point . it throws an error:

TypeError: Cannot read property 'render' of undefined
at normalizeRender (node_modules\vue-server-renderer\build.js:5192:19)

it looks like a compatibility problem of bundle rendering with ES5.

I changed the codes in node_modules/vue-server-renderer/build.js to the following:

if(typeof m.exports === 'function'){
  resolve(m.exports(_context))
  return
}

var res = Object.prototype.hasOwnProperty.call(m.exports, 'default')
  ? m.exports.default
  : m

then it works.

[speedornothing]

if needed, i could supply my test case

function renderCode(code, context, callback){
  var createBundleRenderer = require('vue-server-renderer').createBundleRenderer
  var renderer = createBundleRenderer(code)
  renderer.renderToString(context, callback)
}

it('bundle-rendering-es5-compatibility', function(done){
  var bundleCode = [
    'var Vue = require(\'vue\')',
    'module.exports = function(context){',
    '  return new Promise(function(resolve, reject){',
    '    resolve(new Vue({',
    '      template: \'<div id="app">app</div>\'',
    '    }))',
    '  })',
    '}'
  ].join('\n')

  renderCode(bundleCode, {}, function(err, html){
    if(err){
      done(err)
      return
    }
    try{
      html.should.equal('<div id="app" server-rendered="true">app</div>')
    } catch(e){
      done(e)
      return
    }
    done()
  })
})

[AlbertMarashi]

@yyx990803 why was this closed

[jacekkarczmarczyk]

Because if was fixed

You can create a new issue if you have reproduction showing that the bug still exists

[AlbertMarashi]

@jacekkarczmarczyk I'm using the new node 13 Import/Exports. Could this have anything to do with it?

[AlbertMarashi]

This only occurs when I am adding or removing a new import to a vue file, restarting the server fixes the issue. Not sure why this occurs

[jacekkarczmarczyk]

No idea, create a minimal reproduction and open a new issue or ask in discord/forum/etc