add getTypeList to process mutli-type prop #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
requested changes
Oct 9, 2016
| @@ -21,7 +21,7 @@ export function validateProp ( | |||
| const absent = !hasOwn(propsData, key) | |||
| let value = propsData[key] | |||
| // handle boolean props | |||
| if (getType(prop.type) === 'Boolean') { | |||
| if (getTypeList(prop.type).indexOf('Boolean') >= 0) { | |||
There was a problem hiding this comment.
Since this function is pretty perf-sensitive, I'd suggest a isBooleanType(prop.type) function that:
- If
prop.typeis Array, iterate withforand return if any equals'Boolean' - otherwise just check
=== 'Boolean'.
fooosmar
approved these changes
Oct 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the getType func only returns the first prop type, even if the prop type is an array.
Add getTypeList func to get prop types.
fix #3879