Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DevTools perfromance user timing measurement name #6624

Merged
merged 1 commit into from Oct 2, 2017

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Sep 16, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Vue core is marked with performance.measure too vague. (e.g. <Root> render)
I think it's difficult to understand intuitively in devtools performance timeline.

the following devtools performance timeline capturing image:
performance-timeline

And also vue performance measurement with headless browser API (e.g. puppeteer) is hard to parse from profile data.

the following profile data capturing image:

hard-to-parsing

I hope improvement.

@yyx990803 yyx990803 merged commit 894d380 into vuejs:dev Oct 2, 2017
@kazupon kazupon deleted the improve/perf branch October 2, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants