Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend config keyCodes property type to accept an array of numbers #6745

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Extend config keyCodes property type to accept an array of numbers #6745

merged 1 commit into from
Oct 6, 2017

Conversation

alexeden
Copy link
Contributor

@alexeden alexeden commented Oct 6, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Modification of Vue's static config property type definition.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

Other information:

image

Per the documentation of the Vue config's keyCodes object, the value of a keyCodes property may be either a number or an array of numbers. The current keyCodes type definition only accepts a single, non-array number. This PR corrects the type definition to reflect both types of acceptable values.

@yyx990803 yyx990803 merged commit 64e3943 into vuejs:dev Oct 6, 2017
@alexeden alexeden deleted the config-keycodes-typing branch October 6, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants