Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary checks #7875

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Conversation

HcySunYang
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Through the processing of the mergeOptions function, the type of vm.$options.data is either a function or undefined. And in the initState function has filtered out the possibility of undefined, so in the initData function vm.$options.data must be a function

@yyx990803 yyx990803 merged commit 43551b4 into vuejs:dev Mar 22, 2018
yyx990803 added a commit that referenced this pull request Mar 22, 2018
@jo0ger
Copy link

jo0ger commented Jun 26, 2018

Hi, I think these checks are necessary.
For example:

const app = new Vue({
    el: '#app',
    data: {
        name: 'Jooger'
    },
    beforeCreate () {
        this.$options.data = {
            name: 'Jooger2'
        }
    }
})

Because beforeCreate is executed before initData, it is necessary to check the data type in initData if I change vm.$option.data in beforeCreate

@posva
Copy link
Member

posva commented Jun 26, 2018

@jo0ger They were reverted

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants