Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(for): use IE compatible regex in v-for regex #8048

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

posva
Copy link
Member

@posva posva commented Apr 18, 2018

Closes #7946

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva
Copy link
Member Author

posva commented Apr 18, 2018

Credit to @schoonc for pointing out the fix

@cleptric
Copy link

cleptric commented Aug 7, 2018

Is there something left, I could help with, to get this merged?

@cyberzed
Copy link

@sodatea is there any plans for merging this one or it's left in the dark alone forever :)

Copy link

@ffMathy ffMathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@cleptric
Copy link

How can this take 6 months to get a fix for a breaking change, in a supported browser, getting merged? Does vue not care about IE10 anymore?

@TheWebTech
Copy link

I'm here to bump this PR again as @cleptric stated, this is a simple fix that fixes support for a major feature of Vue for IE.

@yyx990803 yyx990803 merged commit ecc239e into vuejs:dev Oct 24, 2018
@posva posva deleted the fix/7946 branch October 24, 2018 18:04
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using v-for in IE10
7 participants