Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async option #8240

Merged
merged 7 commits into from Aug 16, 2018
Merged

Add async option #8240

merged 7 commits into from Aug 16, 2018

Conversation

eddyerburgh
Copy link
Member

@eddyerburgh eddyerburgh commented May 23, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

Other information:

Closes #8200

We can use this in Vue Test Utils to run tests synchronously without editing Vue internals

@posva
Copy link
Member

posva commented May 23, 2018

Do you think it would make sense to use an ENV variable so it is completely stripped out in normal builds?

@trollepierre
Copy link

what's up with this amazing feature?

@eddyerburgh eddyerburgh changed the title Add async option WIP Add async option Jul 14, 2018
@eddyerburgh eddyerburgh changed the title WIP Add async option Add async option Jul 21, 2018
@eddyerburgh
Copy link
Member Author

Example repo using this branch with Vue Test Utils—https://github.com/eddyerburgh/vue-sync-proof-of-concept

@sobrinho
Copy link

Waiting for that too, Vuetify is near impossible to test on vue-test-utils.

I'm seeing errors related to _transitionClasses not defined everywhere.

@yyx990803 yyx990803 merged commit c944827 into vuejs:dev Aug 16, 2018
@benirose
Copy link

Is this still going into 2.6?

@eddyerburgh
Copy link
Member Author

It should be out in 2.5.18

@aldarund
Copy link

@eddyerburgh is there any ETA on 2.5.18 ?

@agualis
Copy link

agualis commented Dec 4, 2018

@eddyerburgh is there any ETA on 2.5.18 ?
🎉 🎉
https://github.com/vuejs/vue/releases/tag/v2.5.18-beta.0

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
This is an option intended only for testing purposes, and should not be used in
application code.
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
This is an option intended only for testing purposes, and should not be used in
application code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement async config option
8 participants