Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): avoid this in VueConstructor signature #9173

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

HerringtonDarkholme
Copy link
Member

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:

Fix vuejs/vue-class-component#294

Mixing this, interface, extends and new signature seems to be hairy in TypeScript. It is better to not rely on this.

@ktsn
Copy link
Member

ktsn commented Dec 10, 2018

@HerringtonDarkholme Thanks! Can we add a test case for decorator usage?

@HerringtonDarkholme
Copy link
Member Author

@ktsn Indeed. I found vue-class-component bug can be only reproduced in decorator usage, Component(VueComp) will successfully compile.

It requires us to switch on experimentalDecorator flag. Is it fine?

@ktsn
Copy link
Member

ktsn commented Dec 10, 2018

@HerringtonDarkholme I think it is fine. Do you have any concern about that?

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with Vue 2.5.18
3 participants