-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataAttributes
option
#125
Comments
Why we have to declare what are the attributes of the components? Can't we just use whatever the user writes as attribute automatically? |
because then we have to blacklist native attributes depending on the element type, which can be cumbersome. A whitelist approach is explicit and safer. |
I think 'dataAttributes' is a bit misleading, potential confusion with the datatset api ? Perhaps 'bindAttributes' ? For example, this seems odd,
Whereas,
We'd need to rename the binding key in this instance as well, this['data-qty'], seems messy.
|
yes, but bindAttributes also sounds misleading because we are not really binding it, its just a starting value. Maybe |
|
+1 for paramAttributes
|
Ah, mis-thought the whole binding part. Initial data, I follow now! Absolutely, paramAttributes sounds perfect for what you describe. |
how about the dead simple attr ? |
@marfalkov there is already an |
So this is the exact opposite. Maybe the names could reflect that, with something like |
setAttributes and getAttributes sounds good |
I don't think they are logical counterparts - |
@yyx990803 that makes sense. |
This seems to be a better solution than
v-data
, which is confusing.v-data
will likely be removed in the next release.The text was updated successfully, but these errors were encountered: