The $on()’s callback is bound to the event object #130

bpierre · 2014-02-23T12:19:01Z

var vm = new Vue({
    created: function() {
        console.log(this === vm) // true

        this.$watch('foo', function() {
            console.log(this === vm) // true
        })

        this.$on('bar', function(value) {
            console.log(this === vm) // false
        })
    }
})

Shouldn’t this be the current VM here? Maybe the event could be passed as a second parameter.

The text was updated successfully, but these errors were encountered:

marfalkov · 2014-02-23T13:03:18Z

Since I'm using this way it doesn't really bother me but this is a good point.

var vm = new Vue({
    created: function() {
        var self = this
        console.log(self === vm) // true

        this.$watch('foo', function() {
            console.log(self === vm) // true
        })

        this.$on('bar', function(value) {
            console.log(self === vm) // true
        })
    }
})

bpierre · 2014-02-23T13:16:08Z

Yes that’s what I am doing at the moment, I am just wondering if it’s on purpose.

This has a few benefits - no longer need to shiv the difference between Component's emitter & Browserify's emitter (node version) - no longer need to hack around Browserify's static require parsing - able to drop methods not used in Vue - able to add custom callback context control, as mentioned in #130

yyx990803 closed this as completed Feb 23, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The $on()’s callback is bound to the event object #130

The $on()’s callback is bound to the event object #130

bpierre commented Feb 23, 2014

marfalkov commented Feb 23, 2014

bpierre commented Feb 23, 2014

The $on()’s callback is bound to the event object #130

The $on()’s callback is bound to the event object #130

Comments

bpierre commented Feb 23, 2014

marfalkov commented Feb 23, 2014

bpierre commented Feb 23, 2014