Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering problems with v-if in vue-2.0-beta.1 #3247

Closed
cemelo opened this issue Jul 8, 2016 · 2 comments
Closed

Rendering problems with v-if in vue-2.0-beta.1 #3247

cemelo opened this issue Jul 8, 2016 · 2 comments
Labels
bug

Comments

@cemelo
Copy link

cemelo commented Jul 8, 2016

Vue.js version

2.0.0-beta.1

Reproduction Link

https://jsfiddle.net/ybh4w2sx/

Steps to reproduce

  • Given some DOM element and a variable x, create an element with a v-if directive bound to the variable x and, optionally, a transition set.
  • Toggle the variable a few times.

What is Expected?

The DOM element should be removed and attached several times to the parent. If the transition is set, it should be applied also.

What is actually happening?

The behaviour is erratic. Sometimes the element is rendered correctly, but eventually the next sibling is attached instead. Also, if a transition is set, it isn't applied at all.
yyx990803 added a commit that referenced this issue Jul 8, 2016
@yyx990803
ensure unique key for elements with transition (fix #3247)
0764ae2
@cemelo
Copy link
Author

cemelo commented Jul 10, 2016 •
edited

@yyx990803 now, (1) when you show the item while transitioning, a duplicated element is added to the DOM, as seen in https://jsfiddle.net/ybh4w2sx/8/. Also, (2) if you have two elements with the v-if directive, the vm inserts the wrong element. The fiddle was updated to better enlighten you about the bug.

Edit: (1) only happens when the element is leaving the DOM.

@yyx990803
Copy link
Member

@cemelo thanks for the update. I think the 2.0 transition system needs to be revised to deal with vdom updates like this - stay tuned for beta.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yyx990803 @cemelo