Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flow to 0.30.0 #3482

Closed
hatashiro opened this issue Aug 19, 2016 · 0 comments
Closed

Upgrade Flow to 0.30.0 #3482

hatashiro opened this issue Aug 19, 2016 · 0 comments

Comments

@hatashiro
Copy link
Contributor

hatashiro commented Aug 19, 2016

I've recently started to read code on the next branch, and found that Flow is used to check types. I think it's really a wise decision to statically analyse types for more reliable code base.

However, I found that vim-flow reported errors. The errors occur in Flow 0.30.0, which I installed in my global env. I understand it's not an urgent issue and it's completely okay for now to stick to the current version, but it's always good to get prepared.

FYI, errors are about string interpolation for Maybe type. An example is listed below:

src/compiler/codegen/index.js:77
 77:   return `(${exp})?${genElement(el)}:${genElse(el)}`
                  ^^^ undefined. This type cannot be added to
 77:   return `(${exp})?${genElement(el)}:${genElse(el)}`
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ string

If you don't mind, I'd like to help this issue to be resolved. Please feel free to drop a comment.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants