Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function wiring broken for components that show/hide slot content using v-show #3556

Closed
analog-nico opened this issue Aug 29, 2016 · 1 comment

Comments

@analog-nico
Copy link

I reported the same issue for v-if which got fixed in vue@2.0.0-rc.4. However, with this version the same code using v-show – which previously worked perfectly – does not work anymore.

Vue.js version

2.0.0-rc.4

Reproduction Link

http://codepen.io/analog-nico/pen/KgPKRq

Steps to reproduce

  1. Click the link "Open popup using v-show"
  2. A badly designed popup opens
  3. Click the "Close" link

What is Expected?

  • The popup closes successfully

What is actually happening?

  • Vue fails to call an internal function and throws: TypeError: o.fn is not a function. (In 'o.fn(ev)', 'o.fn' is an instance of Object)
  • The closePopupUsingVShow function attached to the "Close" link's click event never gets called.
  • The popup does not close.

For reference the codepen contains the exact same implementation of the popup with the only difference that it uses v-if instead of v-show to show/hide the popup. v-if works perfectly.

@analog-nico
Copy link
Author

Thanks a lot! Works perfectly in RC 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants