Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render functions behaviour changed without notice #3919

Closed
miljan-aleksic opened this issue Oct 12, 2016 · 1 comment
Closed

Render functions behaviour changed without notice #3919

miljan-aleksic opened this issue Oct 12, 2016 · 1 comment
Labels
regression

Comments

@miljan-aleksic
Copy link

miljan-aleksic commented Oct 12, 2016 •
edited

Since version 2.0.2 there are subtle changes in how createElement behave.

  1. The createElement first argument, if a String, can only by HTML tag. Prior it was accepting globally registered components.
  2. The render function must return some value. Before it was not getting rendered without rising errors.

Both examples raise the Cannot set property 'functionalContext' of undefined error.

JSFiddle Link

http://jsfiddle.net/miljan/vqpwdfrf/2/
@miljan-aleksic
Copy link
Author

Correction on point 1. It still support custom components, which could be documented, btw.

Correction on point 2, its about Functional Components. They should be able to return anything, even empty string if required, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yyx990803 @miljan-aleksic