Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-type prop validation [Boolean, String] cast empty string to true #4538

Closed
fliptheweb opened this issue Dec 21, 2016 · 1 comment
Closed

Multi-type prop validation [Boolean, String] cast empty string to true #4538

fliptheweb opened this issue Dec 21, 2016 · 1 comment

Comments

@fliptheweb
Copy link
Contributor

fliptheweb commented Dec 21, 2016 •
edited

Vue.js version

2.0.2

Reproduction Link

https://jsfiddle.net/fliptheweb/zjr41svn/4/

Steps to reproduce

What is Expected?

An empty string '' must pass to the component like an empty string.

What is actually happening?

It's type cast type to boolean true
@fliptheweb
Copy link
Contributor Author

fliptheweb commented Dec 21, 2016 •
edited

It seems that if types validation includes String and Boolean together, we should not check here for the blank line.

There is another case when we have hyphenated string that looks like a prop.

@fliptheweb fliptheweb mentioned this issue Dec 21, 2016
Merged
fliptheweb added a commit to fliptheweb/vue that referenced this issue Dec 21, 2016
@fliptheweb
don`t cast empty string to Boolean if prop types include String and B…
362a322 
…oolean (fix vuejs#4538)
@frandiox frandiox mentioned this issue Jan 26, 2017
Closed
@Kingwl Kingwl mentioned this issue Jun 23, 2017
Closed
@mirik-k mirik-k mentioned this issue Jan 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fliptheweb