Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition flickering with 2.1.7 #4576

Closed
luventa opened this issue Dec 27, 2016 · 6 comments
Closed

Transition flickering with 2.1.7 #4576

luventa opened this issue Dec 27, 2016 · 6 comments
Labels
regression

Comments

@luventa
Copy link

luventa commented Dec 27, 2016 •
edited

Related issue was raised by StarpTech in vue-admin yesterday.
Repo example is based on vue-router example...
The workaround is

Add attribute enter-class="fadeIn" into transition

or

Change vue.js back to 2.1.6

Vue.js version

2.1.7

Reproduction Link

http://codepen.io/anon/pen/RozKBz

Steps to reproduce

Switch the view between Foo and Bar by hitting the a links.

What is Expected?

Transition works fluently.

What is actually happening?

View flickers during transition.
@luventa luventa changed the title Transition is flickering with 2.1.7 Transition flickering with 2.1.7 Dec 27, 2016
@fundon
Copy link

fundon commented Dec 27, 2016

2.1.6 without this problem.

@sqal
Copy link
Contributor

sqal commented Dec 27, 2016 •
edited

2.1.7 broke transition for me too. Please check these JSFiddles:

2.1.6 - https://jsfiddle.net/sqal/5bwy3fpw/
2.1.7 - https://jsfiddle.net/sqal/5bwy3fpw/1/

Steps to reproduce

  • click fast multiple times on checked radio button.

You can clearly see that ripple effect in 2.1.7 doesn't behave the same as in 2.1.6. The release notes for 2.1.7 says that <transition>should not be affected by this update, but it is. Should I update something in my CSS or JS to fix this problem?

@LinusBorg LinusBorg added the 2.1 label Dec 27, 2016
@sqal
Copy link
Contributor

sqal commented Dec 27, 2016 •
edited

@yyx990803 Is 89987e8 also supposed to fix my issue? I checked this quickly by editing dist file (vue/dist/vue.runtime.common.js) with your change but same result.

@yyx990803
Copy link
Member

@sqal ah, sorry, it indeed affects <transition> usage. I think I'll have to revert this whole change...

yyx990803 added a commit that referenced this issue Dec 27, 2016
@yyx990803
Revert "fix enter transition flicker regression (fix #4576)"
0bb2d4e 
This reverts commit 89987e8.
@yyx990803
Copy link
Member

@sqal I've reverted it to the old behavior and your use case should work as expected in the next release.

@luventa
Copy link
Author

luventa commented Dec 27, 2016 •
edited

@yyx990803 Thanks alot for dealing with this issue!

@luventa luventa mentioned this issue Dec 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fundon @yyx990803 @LinusBorg @sqal @luventa