New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSR ]update warning message about runtime/standalone builds #4680

Closed

LinusBorg opened this issue Jan 9, 2017 · 1 comment

Labels

Member

LinusBorg commented Jan 9, 2017

Currently, SSR will warn like this when a standalone build is used in the SSR bundle:

[vue-server-renderer] You are using the standalone build (vue/dist/vue.js) for server-side rendering. It is recommended to use the CommonJS build (vue/dist/vue.common.js) instead so that the code can run in production mode by setting NODE_ENV=production. The server renderer supports the template option regardless of what build you are using.

After the new build introduced with Vue 2.1, this should probably read:

[vue-server-renderer] You are using the standalone build (vue/dist/vue.common,js) for server-side rendering. It is recommended to use the runtime-only CommonJS build (vue/dist/vue.runtime.common.js) instead so that the code can run in production mode by setting NODE_ENV=production. The server renderer supports the template option regardless of what build you are using.

LinusBorg added 2.1 improvement labels

yyx990803 closed this as completed in

b60182d

Member

yyx990803 commented Jan 11, 2017

Actually with the new dist file setup, users will most likely be using CommonJS builds by default, so this check is no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment