Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late-injected options of constructors are dropped in resolveComponentOptions function #4976

Closed
chanon opened this issue Feb 20, 2017 · 0 comments
Labels

Comments

@chanon
Copy link

chanon commented Feb 20, 2017

While investigating the cause of vuejs/vue-class-component#65 related to vue-hot-reload not working with vue-class-component, @ktsn found a bug in vue core which he noted here:
vuejs/vue-class-component#65 (comment)

He says

I find there is a bug in core library that accidentally drop late-injected options of constructors. That means, if we use vue-hot-reload-api or vue-loader, they inject some options into component options object after creating component constructors, then the component is instantiated by using constructor with $createElement and the injected options are dropped in resolveComponentOptions function.

And that it is also causing vuejs/vue-class-component#66

Here is the minimal reproduction of this bug by @ktsn
https://jsfiddle.net/vvxLyLvq/2/

I don't know much about it, I'm just creating the issue here for @ktsn

In summary this issue is causing vue-class-component hot-reload to not work and also makes using vue-class-component with CSS Modules impossible.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants