New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createBundleRenderer('/path/to/bundle.json') failed #5037

Closed

wongyouth opened this issue Feb 28, 2017 · 1 comment

wongyouth commented Feb 28, 2017

createBundleRenderer('/path/to/bundle.json') failed.
but createBundleRenderer(require('/path/to/bundle.json')) succeed

And I found the pattern /\.json$/ is tested based on file content but not based on file name:

bundle = fs.readFileSync(bundle, 'utf-8')
   if (/\.json$/.test(bundle)) {

see
https://github.com/vuejs/vue/blob/dev/src/server/create-bundle-renderer.js#L47-L48

The text was updated successfully, but these errors were encountered:

yyx990803 closed this as completed in

367f781

Member

yyx990803 commented Feb 28, 2017

Thanks for locating the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment