Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v-on:keydown.right and left seems to be broken in Vue 2.2.1 #5046

Closed
grofzero opened this issue Mar 1, 2017 · 4 comments
Closed

v-on:keydown.right and left seems to be broken in Vue 2.2.1 #5046

grofzero opened this issue Mar 1, 2017 · 4 comments
Labels
regression

Comments

@grofzero
Copy link

grofzero commented Mar 1, 2017

Hi,

Upgrading to 2.2.1 broke the following line

  • Right and left modifiers on keydown seems to be broken, but v-on:keydown.39 is still working.

    Thanks in advance,
    grofzero

    		•
    @Akryum
    Copy link
    Member

    Akryum commented Mar 1, 2017 •
    edited

    Thanks for filing the issue. Please follow the Issue Reporting Guidelines and provide a minimal JSFiddle or JSBin containing a set of reproducible steps that can lead to the behavior you described.

    Why is this required?

    BTW, I made a repro: https://jsfiddle.net/Akryum/9noa3eu5/

    @Akryum Akryum removed the need repro label Mar 1, 2017
    @grofzero
    Copy link
    Author

    grofzero commented Mar 1, 2017

    Sorry, and thanks for the repro

    @Kingwl Kingwl mentioned this issue Mar 2, 2017
    Closed
    @Kingwl
    Copy link
    Member

    Kingwl commented Mar 2, 2017 •
    edited

    i'm sorry about this problem
    I think this is what I have caused
    and the unit test have not cover that
    @Akryum

    @posva
    Copy link
    Member

    posva commented Mar 2, 2017

    @Kingwl It's ok 🙂

    yyx990803 added a commit that referenced this issue Mar 3, 2017
    @yyx990803
    fix v-on .left .right compat with keyboard events (fix #5046)
    3294eba
    @st-sloth st-sloth mentioned this issue Nov 14, 2017
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    regression
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @posva @grofzero @LinusBorg @Akryum @Kingwl