Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange interaction of filter in 0.11.0-rc2 #506

Closed
franciscolourenco opened this issue Oct 23, 2014 · 4 comments
Closed

Strange interaction of filter in 0.11.0-rc2 #506

franciscolourenco opened this issue Oct 23, 2014 · 4 comments

Comments

@franciscolourenco
Copy link
Contributor

Without the filter, you can move the slider past the computed limit.
Adding a bogus filter is enough to prevent the slider thumb from going past the limit.
Why does this happen?
http://jsfiddle.net/zancs8x3/1/

Edit: doesn't happen with 0.10.6: http://jsfiddle.net/1xrh4r0g/
yyx990803 added a commit that referenced this issue Oct 24, 2014
@yyx990803
fix #506 unify v-model listener behavior with/without filters
b3b2380
@yyx990803
Copy link
Member

It's an interesting side effect of some internal mechanism to deal with filters that turns out to fix the out-of-bound issue for range inputs...

@franciscolourenco franciscolourenco mentioned this issue Nov 22, 2014
Closed
@franciscolourenco
Copy link
Contributor Author

Should this be re-opened?
Commit 25fb48d in dev brings back the issue:
http://jsfiddle.net/y5sdor2h/
http://jsfiddle.net/p2s3hbr1/

0.11.0 behaviour seems great for range inputs though..

@yyx990803
Copy link
Member

Hmm... reverting seems like a bad idea.

@yyx990803
Copy link
Member

Had to make type="range" a special case here: yyx990803/vue@ed65dec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@franciscolourenco @yyx990803