Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug of function removeClass #76

Closed
jzlxiaohei opened this issue Feb 7, 2014 · 2 comments
Closed

bug of function removeClass #76

jzlxiaohei opened this issue Feb 7, 2014 · 2 comments
Labels
bug

Comments

@jzlxiaohei
Copy link

vue.js(for dev) , Line 817, removeClass funciton,else branch

             //assume el.className='red yellow green'
             el.className = (' ' + 'red yellow green' + ' ')
            .replace(' ' + 'yellow' + ' ', '')
            .trim()
            // will be 'redgreen',not 'red green'
@yyx990803
Copy link
Member

ohhh thanks. good catch

@yyx990803 yyx990803 added the bug label Feb 7, 2014
yyx990803 added a commit that referenced this issue Feb 7, 2014
@yyx990803
fix #76 removeClass
4fdeba5
@yyx990803
Copy link
Member

fixed in 4fdeba5

Hanks10100 pushed a commit to Hanks10100/vue that referenced this issue May 6, 2018
@aOrz
Merge pull request vuejs#76 from Meituan-Dianping/develop
28850bc 
new version 1.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yyx990803 @jzlxiaohei