Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Loop With Error Handler And Vuex #1505

Closed
visualjerk opened this Issue Feb 12, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@visualjerk
Copy link

visualjerk commented Feb 12, 2019

Version

2.5.0

Reproduction link

https://codesandbox.io/s/z6ww1zp2q4

Steps to reproduce

  • open browser console

What is expected?

Not getting an infinite render loop:
[Vue warn]: You may have an infinite update loop in a component render function.

What is actually happening?

Getting an infinite render loop


This happens when you handle an error that was caused during rendering and try to commit it to the store.

It looks like a component that throws an error tries to rerender after the store is updated, even so it doesn't use the store's state.

@Laslo89

This comment has been minimized.

Copy link

Laslo89 commented Feb 13, 2019

I run into the same issue...

@ktsn

This comment has been minimized.

Copy link
Member

ktsn commented Feb 13, 2019

This is actually Vue core lib's issue. I already made a PR for fix. vuejs/vue#9489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.