Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sameAs validator #66

Closed
ecmel opened this issue Feb 5, 2017 · 1 comment
Closed

sameAs validator #66

ecmel opened this issue Feb 5, 2017 · 1 comment
Labels
bug

Comments

@ecmel
Copy link
Contributor

ecmel commented Feb 5, 2017 •
edited

sameAs validator should NOT return true for null, undefined and empty values, instead it should return true if they are both null, undefined or empty.
@shentao
Copy link
Member

shentao commented Feb 11, 2017

Good catch! Thank you!

@shentao shentao added the bug label Feb 11, 2017
@ecmel ecmel mentioned this issue Feb 11, 2017
Merged
@ecmel ecmel closed this as completed Feb 11, 2017
@nicolas-guichard nicolas-guichard mentioned this issue Aug 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecmel @shentao