Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] plugin-active-header-links trigger route.path changes #1290

Closed
Mister-Hope opened this issue Mar 26, 2023 · 2 comments
Closed

[Bug report] plugin-active-header-links trigger route.path changes #1290

Mister-Hope opened this issue Mar 26, 2023 · 2 comments
Assignees
@meteorlxy
Labels
bug Something isn't working

Comments

@Mister-Hope
Copy link
Member

Mister-Hope commented Mar 26, 2023 •
edited

Description

When users scrolling pages, all watches with route.path deps shall not be triggered, however @vuepress/plugin-active-header-links break this. Every computed value and watches with route.path will be recalculated or rerun when hash changes or page scrolling to top.

Reproduction

https://stackblitz.com/edit/vuepress-ewt9uy?file=package.json,docs%2Fguide%2FREADME.md%3AL40,package-lock.json

Used Package Manager

npm

System Info

Not related
@Mister-Hope Mister-Hope added the bug Something isn't working label Mar 26, 2023
@Mister-Hope
Copy link
Member Author

Mister-Hope commented Jun 8, 2023 •
edited

Could you explain why force: true is needed when changing hash? @meteorlxy

This is affecting every deps which depend on route.path.

@Mister-Hope Mister-Hope mentioned this issue Jun 8, 2023
Closed
@meteorlxy
Copy link
Member

This should have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorlxy meteorlxy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meteorlxy @Mister-Hope