Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(markdown): handle data uri correctly, close #1393 #1403

Merged
merged 2 commits into from Aug 28, 2023
Merged

fix(markdown): handle data uri correctly, close #1393 #1403

merged 2 commits into from Aug 28, 2023

Conversation

Mister-Hope
Copy link
Member

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Documentation update
  • Other

Description

Screenshots

Before

After

@Mister-Hope Mister-Hope linked an issue Aug 28, 2023 that may be closed by this pull request
#1103 breaks data uri images #1393
Closed
@meteorlxy
Copy link
Member

@Mister-Hope Please resolve the CI error

@meteorlxy meteorlxy merged commit bd8aa0a into main Aug 28, 2023
29 checks passed
@meteorlxy meteorlxy deleted the markdown/image branch August 28, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy meteorlxy approved these changes

Assignees
No one assigned
Labels
package:markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#1103 breaks data uri images
2 participants
@Mister-Hope @meteorlxy