Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-default): nomalize rem size #817

Merged
merged 3 commits into from May 3, 2022
Merged

Conversation

Mister-Hope
Copy link
Member

No description provided.

@Mister-Hope
Copy link
Member Author

@meteorlxy Inspired by #816, following root font size have better a11y.

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Apr 14, 2022

Then how about adding an addtion style:

: root {
  font-size: 16px;
}

or

html {
  font-size: 16px;
}

Anyway, my idea is we should not unbind font-size of main text with rem, while let the remaining site elment bind with rem.

@Mister-Hope Mister-Hope changed the title feat(theme-default): use rem for body font-size feat(theme-default): nomalize rem size Apr 14, 2022
@meteorlxy
Copy link
Member

What about simply moving font-size: 16px; to the html, body section? What's the point to specify 1rem for body?

@Mister-Hope
Copy link
Member Author

Setting both as 16 px, user will fail to change body font-size when simply setting a new rem size.

@meteorlxy meteorlxy merged commit fd26901 into main May 3, 2022
@meteorlxy meteorlxy deleted the default-theme-font-size branch May 3, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants