Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(code): add a way to configure Prism theme #38
I didn't like Prism theme
(Don't take care of highlighted lines, it's part of #37
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
For now, you can use index.stly to override it, such as:
//index.stly @import '~prismjs/themes/prism-twilight.css'
Since our code block background is always black, some theme might not be suitable.
AFAIK, VP's default theme doesn't support configuring Prism theme. I can't confirm whether it should be supported, but it's worthwhile to open an issue in VuePress, and we can follow the decision.
Yes, VP's default theme does not support configuring Prism theme, they directly use
Using your solution won't work properly because Prism is still imported with
I will open a new PR to remove