Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Upgrading to 1.0.2 #1377

Closed
1 task done
bensinca opened this issue Oct 6, 2022 · 1 comment
Closed
1 task done

[Bug]: Upgrading to 1.0.2 #1377

bensinca opened this issue Oct 6, 2022 · 1 comment
Labels
bug Something isn't working triage-needed Issues that need to be checked

Comments

@bensinca
Copy link
Contributor

bensinca commented Oct 6, 2022

Expected Behavior

When upgrading to 1.0.2 or installing a fresh 1.0.2 there shouldn't be any packages mismatch.

Actual Behavior

On yarn dev

  Vue packages version mismatch:
  
  - vue@2.6.14 (node_modules/vue/dist/vue.runtime.common.js)
  - vue-template-compiler@2.7.10 (node_modules/vue-template-compiler/package.json)
  
  This may cause things to work incorrectly. Make sure to use the same version for both.
  If you are using vue-loader@>=10.0, simply update vue-template-compiler.
  If you are using vue-loader@<10.0 or vueify, re-installing vue-loader/vueify should bump vue-template-compiler to the latest.

Possible Solution

Darren R replied in discord, that it could be related to Storefront UI
https://discord.com/channels/770285988244750366/1025358481894686720

@nuxtjs/composition-api": "^0.31.0" package .json peerDependencies is requiring that vue to be "vue": "^2.7.10"
the vue version in here: https://github.com/vuestorefront/magento2/blob/main/packages/theme/package.json is set to 2.6.14. However, the nuxt/composition-api is required for vue to be "vue": "^2.7.10"

Steps to reproduce

No response

What version of Magento 2 integration are you using?

1.0.2

What version of Node.js are you using?

16.17.0

What browser (and version) are you using?

Chrome. Safari

What operating system (and version) are you using?

linux

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bensinca bensinca added bug Something isn't working triage-needed Issues that need to be checked labels Oct 6, 2022
@bensinca
Copy link
Contributor Author

bensinca commented Oct 6, 2022

if you set "vue-template-compiler": "2.6.14" in devDependencies then you will run into vuestorefront/storefront-ui#2494

@bensinca bensinca closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage-needed Issues that need to be checked
Projects
None yet
Development

No branches or pull requests

1 participant