Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(default-theme): Improve SwImage component when no thumbnail #1936

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

quando1910
Copy link
Collaborator

Problem

  • SwImage can not load when there is no thumbnail.

Changes:

  • Update SwImage and CmsElementImage, so it will load with media.url.

@vercel
Copy link

vercel bot commented Aug 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
shopware-pwa-docs ⬜️ Ignored (Inspect) Aug 12, 2022 at 10:01AM (UTC)

@quando1910 quando1910 changed the title feat(default-theme): Improve SwImage component when no thumbnail fix(default-theme): Improve SwImage component when no thumbnail Aug 12, 2022
@github-actions
Copy link

github-actions bot commented Aug 12, 2022

💙 shopware-pwa-test-europe-west1-gcp-storefrontcloud-io successfully deployed at https://d918c86e58489cb8f60fa844f1c1cdaf31818f2b.shopware-pwa-test.preview.europe-west1.gcp.storefrontcloud.io

@patzick patzick merged commit 2c8b383 into master Aug 12, 2022
@patzick patzick deleted the fix/swimage-without-thumbnail branch August 12, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants