feat(shopware-6-client): add newsletter recipient endpoint #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mdanilowicz
changed the title
|
💙 shopware-pwa-test-europe-west1-gcp-storefrontcloud-io successfully deployed at https://8634dea998dd7bcce8e2e437f10b240158f7cbdc.shopware-pwa-test.preview.europe-west1.gcp.storefrontcloud.io |
mkucmus
reviewed
Aug 29, 2022
| export async function isNewsletterSubscriber( | ||
| contextInstance: ShopwareApiInstance = defaultInstance | ||
| ): Promise<{ | ||
| status: string; |
There was a problem hiding this comment.
can we expect here some specific values to add it as an enum or union of strings using types?
There was a problem hiding this comment.
For now, this endpoint is not described in the documentation, which is why I added string, not enum or union. I think that we can change this type when documentation will be updated and we will be sure about all options
mkucmus
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add new newsletter recipient endpoint
Checklist