Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create i18n module #1900

Closed
filrak opened this issue Oct 26, 2018 · 0 comments
Closed

Create i18n module #1900

filrak opened this issue Oct 26, 2018 · 0 comments
Assignees
@bartdominiak
Labels
vs-hackathon Tasks for the Hackathon

Comments

@filrak
Copy link
Collaborator

filrak commented Oct 26, 2018

What is the motivation for adding / enhancing this feature?

i18n functionality is well encapsulated thanks to efforts fo @DavidRouyer . Now it should be refactored to be VS module responsible for translations.

What are the acceptance criteria

  • Move all i18n business logic from core to i18n module. If something can't be moved write about it in the issue so we can discuss the correct approach

Additional information

You can contact @DavidRouyer for additional information. He knows best how to handle this problem ;)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartdominiak bartdominiak

Labels
vs-hackathon Tasks for the Hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@filrak @bartdominiak