Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove markdown-based static pages #2007

Closed
filrak opened this issue Nov 20, 2018 · 2 comments
Closed

Remove markdown-based static pages #2007

filrak opened this issue Nov 20, 2018 · 2 comments
Assignees

Comments

@filrak
Copy link
Collaborator

filrak commented Nov 20, 2018

What is the motivation for adding / enhancing this feature?

This feature appeared to be redundant. It's also complicating our vue-cli pkugin migration plan

We should base demo static pages on simple placeholders or some external cms data.

What are the acceptance criteria

  • remove markdown static pages and remove corresponding business logic
  • replace it with placeholders (can be a static vue component)

Can you complete this feature request by yourself?

I'm busy doing other issues regarding modules ;/

Additional information

@pkarw
Copy link
Collaborator

pkarw commented Nov 23, 2018

We can remove them only if we replace the current mockups (terms and conditions etc ...) with static Vue Components. I don't want to have the demo site dependent on any external service (CMS in this case)

@filrak filrak self-assigned this Nov 26, 2018
@filrak filrak added this to the 1.6 | Modules and performance milestone Nov 26, 2018
@filrak
Copy link
Collaborator Author

filrak commented Nov 26, 2018

Ok, scheduled it for today ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants