Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example how to add custom REST backend #2166

Closed
pkarw opened this issue Jan 11, 2019 · 8 comments
Closed

Add an example how to add custom REST backend #2166

pkarw opened this issue Jan 11, 2019 · 8 comments
Assignees
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can vs-hackathon Tasks for the Hackathon

Comments

@pkarw
Copy link
Collaborator

pkarw commented Jan 11, 2019

What is the motivation for adding / enhancing this feature?

We do have the searchAdapter abstraction layer for API backends. Would be great to add the simplerest API backend that DOES NOT require elasticSearch.

I mean - we should create a simple vue-storefront-api like API which is accepting the QueryObject and returns some items from database + implement the rest methods that we have there. Currently the REST adapter transforms the query to elasticSearchQuery to comply with Elastic DSL. The idea is to not do this as our QueryObject is much simpler than Elastic DSL. For example the graphQL adapter doesn't transorm the query but rather sends the query object as a part of gql query

The idea is to replace the vue-storefront-integration-boilerplate with something simpler.

What are the acceptance criteria

  • simple REST API that can be a base for further 3rd party integrations
@pkarw pkarw added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can vs-hackathon Tasks for the Hackathon labels Jan 11, 2019
@CodeSkills
Copy link
Collaborator

I've started working on REST Api adapter last month, and its halfway done. I should be able to finish this one within this month. (If someone needs it faster I can share what work I have, so just PM me and you can continue)

@pkarw
Copy link
Collaborator Author

pkarw commented Jan 18, 2019

Awesome - maybe push it to some github repo to let other folks to continue on that?

@CodeSkills
Copy link
Collaborator

I have to do some tweaks before publishing it within some repo. I will do so when someone PMs me that they want to continue or when I get time to do so. So feel free to PM me anyone if interested.

@pkarw pkarw self-assigned this Feb 1, 2019
@pkarw
Copy link
Collaborator Author

pkarw commented Feb 1, 2019

@pkarw
Copy link
Collaborator Author

pkarw commented Jun 11, 2019

Real life exmaple of this:
cristian-g/vue-storefront@5c3f4aa...develop

@sandermangel sandermangel added this to Accepted Feature Requests in Issue Kanban Sep 6, 2019
@sandermangel
Copy link
Collaborator

@pkarw was this finished? Can we add the "real life example" to the README maybe? :)

Issue Kanban automation moved this from Accepted Feature Requests to Done Sep 6, 2019
@pkarw pkarw reopened this Sep 6, 2019
Issue Kanban automation moved this from Done to In progress Sep 6, 2019
@pkarw
Copy link
Collaborator Author

pkarw commented Sep 6, 2019

It hasn’t been finished yet :/ let’s keep it open

@OnlyC
Copy link

OnlyC commented Oct 26, 2019

This is what I'm looking for. Wanted to implement VSF to my ERP backend a year ago but building the API with elasticSearch was too complicated for me.

@pkarw pkarw closed this as completed Mar 31, 2020
Issue Kanban automation moved this from In progress to Done Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can vs-hackathon Tasks for the Hackathon
Projects
No open projects
Issue Kanban
  
Done
Development

No branches or pull requests

4 participants