[default] Lack of modal backdrop

[vue-kacper]

Current behavior

Lack of modal backdrop entering "My account" from sidebar menu

Expected behavior

Modal backdrop should be visible

Steps to reproduce the issue

Visit: https://demo.storefrontcloud.io as a guest
Click on the menu
Click "My account"

Additional information

Should be:

[filrak]

Tip - there is an action for showing overlay in ui module

[lorenaramonda]

I'm sorry to tell 😬 that the fix provided seems to "work" only when not logged in but when user are logged in, the submenu links all break by opening the login modal and consequently breaking the toggle of overlay and closing of sidebar.

This problem rise up because of this behavior:

• clicking on the my account link triggers the modal open and sets state.overlay to true (although it still doesn't show the modal to frontend)
• then the click propagation also triggers the closing of the menu by setting again the state.overlay to false but still not showing anything to frontend
• when state.overlay eventually has his own fixed state, modal opens and menu closes but at that point overlay already "knows" that must not show itself

We should find a place, possibly the right one, where checking if a modal is triggered and a overlay is already shown, to not hide it. This should prevent any other similar bug.

[pkarw]

@qiqqq @filrak can You guys Please help in here? We should have this fixed before 1.8

[francescosalvi]

@pkarw I actually have developed a different solution during the hackathon, which I didn't push since is not very clean in my opinion (and there was also the other solution pending); I will when I get back at the pc so you guys can check if it's valid

[pkarw]

Perfect :) Thank You @francescosalvi