Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track my orders page is available for not logged user #2347

Closed
ibugaj opened this issue Feb 2, 2019 · 2 comments
Closed

Track my orders page is available for not logged user #2347

ibugaj opened this issue Feb 2, 2019 · 2 comments
Assignees
@vue-kacper
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront
Milestone
1.8

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Feb 2, 2019

Current behavior

Track my orders page is available for not logged user, it directed on https://demo.storefrontcloud.io/order-tracking

Expected behavior

In my opinion this case should behave like My account page so show notification "You need to be logged in to see this page"

Steps to reproduce the issue

  1. Be on Home page as not logged user
  2. Click on Track my orders (from Footer or hamburger menu)

Environment details

https://demo.storefrontcloud.io/
@pkarw
Copy link
Collaborator

pkarw commented Feb 2, 2019

This is just a static page - I suggest removing the link from the footer.

@pkarw pkarw added bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront labels Feb 2, 2019
@vue-kacper vue-kacper self-assigned this Feb 2, 2019
@vue-kacper vue-kacper mentioned this issue Feb 2, 2019
Merged
@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
@pkarw pkarw closed this as completed Feb 2, 2019
@ibugaj
Copy link
Collaborator Author

ibugaj commented Feb 4, 2019

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vue-kacper vue-kacper

Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@pkarw @vue-kacper @ibugaj