Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register new account permits on two-letter First name #2348

Closed
ibugaj opened this issue Feb 2, 2019 · 4 comments
Closed

Register new account permits on two-letter First name #2348

ibugaj opened this issue Feb 2, 2019 · 4 comments
Assignees
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront
Milestone

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Feb 2, 2019

Current behavior

Creating new account permits on two-letter First name, but on Checkout this field is valid, see:

image

Expected behavior

There shouldn't be discrepancies between the field on account creation and Checkout

Steps to reproduce the issue

  1. Go to Register an account
  2. Fill obligatory fields, but in First name field provide only two letters
  3. Finish creating account
  4. Buy some product - go to checkout and see on Personal Detalis

Environment details

https://demo.storefrontcloud.io

@pkarw pkarw added bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront labels Feb 2, 2019
@vue-kacper vue-kacper self-assigned this Feb 2, 2019
@vue-kacper
Copy link
Contributor

There are really short names like "Ed", "Al" etc. so I'll change name validator to min. 2 characters length for both signup and checkout page.

@vue-kacper vue-kacper mentioned this issue Feb 2, 2019
@pkarw
Copy link
Collaborator

pkarw commented Feb 2, 2019

Please check the Ajv JSON validation schema (which is placem in the vue-Storefront-api) if it nas the same length set for this field:
https://github.com/DivanteLtd/vue-storefront-api/blob/develop/src/models/ -> .schema.json

@pkarw
Copy link
Collaborator

pkarw commented Feb 2, 2019

Please also do check the Order flow afterward (if server isn’t returning any avalidation error)

@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
@pkarw pkarw closed this as completed Feb 2, 2019
@ibugaj
Copy link
Collaborator Author

ibugaj commented Feb 4, 2019

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront
Projects
None yet
Development

No branches or pull requests

3 participants