Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong validation for Zip-code field in Payment section #2349

Closed
ibugaj opened this issue Feb 2, 2019 · 0 comments
Closed

Wrong validation for Zip-code field in Payment section #2349

ibugaj opened this issue Feb 2, 2019 · 0 comments
Assignees
@vue-kacper
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront
Milestone
1.8

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Feb 2, 2019 •
edited

Current behavior

Wrong validation for Zip-code field in Payment section - notification, that Zip-code must have at least three letters, although he has.

image

Expected behavior

There shouldn't be validation, if field is filled with 3 letters.

Steps to reproduce the issue

  1. Add some product to the Cart
  2. Go to checkout
  3. Fill fields for sections 1. Persolnal Detalis and 2. Shipping with correct data
  4. Then fill also Payment section (but without checking checkbox "copy address data from shipping"), but in field Zip-code provide 3 letters

Environment details

https://demo.storefrontcloud.io
@pkarw pkarw added bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront labels Feb 2, 2019
@vue-kacper vue-kacper self-assigned this Feb 2, 2019
@vue-kacper vue-kacper mentioned this issue Feb 2, 2019
Merged
@pkarw pkarw added this to the 1.8 milestone Feb 2, 2019
@pkarw pkarw closed this as completed Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vue-kacper vue-kacper

Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@pkarw @vue-kacper @ibugaj