Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Payment modules #2407

Closed
pkarw opened this issue Feb 10, 2019 · 2 comments
Closed

Refactor Payment modules #2407

pkarw opened this issue Feb 10, 2019 · 2 comments
Labels
3: Medium complexity refactor Code refactoring vs-hackathon Tasks for the Hackathon

Comments

@pkarw
Copy link
Collaborator

pkarw commented Feb 10, 2019

What is the motivation for adding / enhancing this feature?

The current way we set the available payment methods is pretty messy. It's done using events + store methods.

To kee the backward compatibility, we should implement the parallel interface, TypeScripted for managing the payment method + full lifecycle of payment method (changed, applied etc).

The main motivation is how payment methods are implemented right now. Based on the events based logic - they're very error-prone and it's very easy to placeOrder twice - either to not place an order at all :)

What are the acceptance criteria

  • ...
  • ...

Can you complete this feature request by yourself?

Additional information

@pkarw pkarw added the refactor Code refactoring label Feb 10, 2019
@pkarw
Copy link
Collaborator Author

pkarw commented Feb 10, 2019

Related to #2405

@pkarw
Copy link
Collaborator Author

pkarw commented Feb 26, 2019

I see this one as a TS, typed, interface based approach without the event bus involved. Rather hooks like we have with the modules.

In 1.9 current order flow should still work but the new refactored one should become default with all core payment methods refactored to it.

@pkarw pkarw added vs-hackathon Tasks for the Hackathon 3: Medium complexity labels Apr 12, 2019
@filrak filrak closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity refactor Code refactoring vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

2 participants