Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in footer to static pages bug #2452

Closed
jorkvist opened this issue Feb 18, 2019 · 5 comments
Closed

Links in footer to static pages bug #2452

jorkvist opened this issue Feb 18, 2019 · 5 comments
Assignees
Labels
bug Bug reports

Comments

@jorkvist
Copy link

Current behavior

Its a bit hard to test on demo.vuestorefront due to same content on a lot of the static pages. But i see this behavior on my local, when i click on a link in the footer to a static page: As a visitor i see the new page, but if Im already is on a static page, the footer links is not updating anything else then the heading of the page. However, the left menu under the static pages is working as intended.

Expected behavior

The visitor should see the correct static page, even if they are on a static page.

Environment details

  • Browser: Chrome latest
@filrak
Copy link
Collaborator

filrak commented Feb 18, 2019

the truth is we only have one static page and all of them are linking to this one, this is why you don't see any change. Not sure if we should add other pages @pkarw

@pkarw
Copy link
Collaborator

pkarw commented Feb 18, 2019

This is the second bug report for the same thing so the answer is: yes we should take care of that once and for all

@jorkvist
Copy link
Author

@filrak yes, but when i have different content it still shows the same page(/loaded content)from the links from the footer when i already standing on a static page. It just updates the {{ page.title }} but not the activeComponent ().

@gabrielecontitaguali
Copy link

gabrielecontitaguali commented Feb 18, 2019

@jorkvist you can try something like this adding a watch on route change

import { currentStoreView } from '@vue-storefront/core/lib/multistore'

watch: {
    '$route.name': function () {
      this.activeComponent = this.navigation.find(nav => nav.link === this.$route.path) ? this.navigation.find(nav => nav.link === this.$route.path).component : null
    }
  },

@filrak
Copy link
Collaborator

filrak commented Feb 21, 2019

already on it

@pkarw pkarw closed this as completed Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports
Projects
None yet
Development

No branches or pull requests

4 participants