Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can add the same email address many times for subscribing #2459

Closed
ibugaj opened this issue Feb 19, 2019 · 4 comments
Closed

User can add the same email address many times for subscribing #2459

ibugaj opened this issue Feb 19, 2019 · 4 comments
Assignees

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Feb 19, 2019

Current behavior

User can add the same email address many times for subscribing

Expected behavior

Notification, that email address has been added to subscribe before (because, I guess, that discount should be allowed only once time for the same address)

Steps to reproduce the issue

  1. Scroll down page to Subscribe to the newsletter section
    2, Click on Subscribe button
  2. On modal fill field by any email addressand click Subcribe
  3. Repeat steps 2-3 (fill with the same email address)

Environment details

https://test.storefrontcloud.io/

@filrak
Copy link
Collaborator

filrak commented Feb 20, 2019

i guess the mailchimp module is not working anyway @pkarw ?

@pkarw
Copy link
Collaborator

pkarw commented Feb 20, 2019

This behavior was intentional - we should just display some message from Mailchimp in case of re-entry or we can save the state to localStorage probably. This is not the Magento newsletter integration intentionally. I belive it should be saved in localStorage + we should handle the error message from mailchimp and that's all :)

@filrak filrak self-assigned this Feb 20, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 23, 2019

Related to #2754

@janmyszkier
Copy link
Contributor

and possibly #1899

@pkarw pkarw closed this as completed Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants