Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seo friendly urls - bugs #2598

Closed
afirlejczyk opened this issue Mar 15, 2019 · 1 comment
Closed

Seo friendly urls - bugs #2598

afirlejczyk opened this issue Mar 15, 2019 · 1 comment
Assignees
Labels
3: Medium complexity bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@afirlejczyk
Copy link
Contributor

Current behavior

  1. If I disable seo URL I have different category link in the menu and in breadcrumbs.
    In breadcrumbs, I have the correct link with 'c' prefix
    In menu I don't have it "c" prefix -> URL is still generated base on 'full_path'

  2. If I go directly to subcategory page
    https://next.storefrontcloud.io/men/tops-men/jackets-men/jackets-14
    I don't see full menu -> maybe it is connected to the first issue.

Expected behavior

  1. Regardless of new config setting: seo.useUrlDispatcher, we should always get the same URL for the category in the menu and in breadcrumbs.

Steps to reproduce the issue

  1. set seo.useUrlDispatcher to false I check category URL in the menu and in breadcrumbs

Repository

Can you handle fixing this bug by yourself?

NO

@afirlejczyk afirlejczyk added the bug Bug reports label Mar 15, 2019
@pkarw pkarw added P1: Urgent Priority mark - high priority 3: Medium complexity labels Mar 15, 2019
@pkarw
Copy link
Collaborator

pkarw commented Mar 15, 2019

I’m not sure when I’ll be able to fix this one so @patzick and @filrak just feel free to take care of it :)

The second one: we should use formatCategoryLink instead of localizedRoute in both: Sidebar and Breadcrumbs.

The first one: on the other pages the “category/load” is called with the root category level as a filter. In product and category pages by some reason it’s called just for the categories on the breadcrumb path. Something is probably wrong with how breadcrumbs are loaded (?). 1.8.4 works just fine so it must be somehow related to url dispatcher

@pkarw pkarw removed their assignment Mar 15, 2019
@filrak filrak self-assigned this Mar 16, 2019
@pkarw pkarw added this to the 1.9.0 milestone Mar 18, 2019
@filrak filrak removed their assignment Mar 20, 2019
@patzick patzick modified the milestones: 1.9.0, 1.9.0-rc.2 Mar 24, 2019
@pkarw pkarw closed this as completed Mar 25, 2019
@patzick patzick mentioned this issue Mar 25, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Mar 25, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

5 participants