Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSF modules can't extend router #2601

Closed
vue-kacper opened this issue Mar 17, 2019 · 1 comment
Closed

VSF modules can't extend router #2601

vue-kacper opened this issue Mar 17, 2019 · 1 comment
Labels
3: Medium complexity bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes
Milestone
1.9.0-rc.2

Comments

@vue-kacper
Copy link
Contributor

vue-kacper commented Mar 17, 2019 •
edited
Loading

Current behavior

This is example route added by "raw-output-example" module:

https://demo.vuestorefront.io/no-js.html ---> It works
https://next.storefrontcloud.io/no-js.html ---> Doesn't work

Expected behavior

Modules should be able to extend router and add new routes

Steps to reproduce the issue

Problem appears on "develop" branch:

https://next.storefrontcloud.io/no-js.html
@pkarw pkarw added bug Bug reports P1: Urgent Priority mark - high priority 3: Medium complexity labels Mar 18, 2019
@pkarw pkarw added this to the 1.9.0 milestone Mar 18, 2019
@pkarw
Copy link
Collaborator

pkarw commented Mar 20, 2019

Thanks! Another one related to UrlDispatcher :)

@pkarw pkarw closed this as completed Mar 23, 2019
@patzick patzick modified the milestones: 1.9.0, 1.9.0-rc.2 Mar 24, 2019
@pkarw pkarw mentioned this issue Mar 25, 2019
Closed
5 tasks
@patzick patzick mentioned this issue Mar 25, 2019
Merged
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Mar 25, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3: Medium complexity bug Bug reports P1: Urgent Priority mark - high priority QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Milestone
1.9.0-rc.2
Development

No branches or pull requests
4 participants
@pkarw @patzick @alinadivante @vue-kacper