Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images are not lazy loaded by first page load #2641

Closed
pkarw opened this issue Mar 23, 2019 · 3 comments
Closed

Images are not lazy loaded by first page load #2641

pkarw opened this issue Mar 23, 2019 · 3 comments
Assignees
@patzick
Labels
3: Medium complexity bug Bug reports P0: Critical Priority mark - highest one
Milestone
1.9.0-rc.2

Comments

@pkarw
Copy link
Collaborator

pkarw commented Mar 23, 2019

What is the motivation for adding / enhancing this feature?

JS works and when you click through CSR everything works just fine. Images are not loaded just by first SSR page load

9B790F0D-FE6C-47A3-8444-AB156128B036

What are the acceptance criteria

  • images are correctly loaded

Additional information
@pkarw pkarw added bug Bug reports P0: Critical Priority mark - highest one 3: Medium complexity labels Mar 23, 2019
@pkarw
Copy link
Collaborator Author

pkarw commented Mar 23, 2019

This is how the DOM looks like on Safari (iOS):
Screenshot 2019-03-23 11 00 44

@pkarw
Copy link
Collaborator Author

pkarw commented Mar 23, 2019

after adding class product-image--loaded the image is loaded correctly

@pkarw
Copy link
Collaborator Author

pkarw commented Mar 23, 2019

The same issue on Safari Desktop (macosx)

@pkarw pkarw mentioned this issue Mar 23, 2019
Merged
5 tasks
@pkarw pkarw closed this as completed Mar 23, 2019
@patzick patzick added this to the 1.9.0-rc.2 milestone Mar 23, 2019
@patzick patzick mentioned this issue Mar 23, 2019
Merged
5 tasks
@pkarw pkarw mentioned this issue Apr 29, 2019
Closed
@Jensderond Jensderond mentioned this issue May 23, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patzick patzick

Labels
3: Medium complexity bug Bug reports P0: Critical Priority mark - highest one
Projects
None yet
Milestone
1.9.0-rc.2
Development

No branches or pull requests
2 participants
@pkarw @patzick