New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in checkout stack into multiple orders per submit #2663
Comments
This should be fixed to 1.9.0 @lukeromanowicz can you please take a look? |
I investigated a bit this issue.
This solution works for me |
@AndreiBelokopytov thanks for Your insights! Could you provide the fix in a form of Pull Request please? |
Sure, I will do it |
Hmm ... I looked at it again and thought that the problem is more complicated.
Which will be better to implement now? |
I belive we should do both: changing error statuses inside Vue-storefront-api. Add general workaround - hotifx to not queue orders in case of http error other than 200 (we should use the queue only for network outage / offline mode - in this case there is no http error at all rather there we have a fetch exception) |
I believe that #2753 would help a lot in this case. |
Somehow related to #2740 |
Current behavior
The more times you submit an order with invalid data (i.e. only numbers in the name fields) the more times there will be a submit order request sent to the backend. First submit will send only one request, another submit w/o fixing errors will send the order twice, etc.
Expected behavior
Order requests having error are being repeated over and over.
Steps to reproduce the issue
Can you handle fixing this bug by yourself?
Which Release Cycle state this refers to? Info for developer.
Pick one option.
develop
branch and create Pull Request2. Feature / Improvement
back todevelop
.release
branch and create Pull Request3. Stabilisation fix
back torelease
.hotfix
ormaster
branch and create Pull Request4. Hotfix
back tohotfix
.Environment details
The text was updated successfully, but these errors were encountered: